Switch GHA runners to Ubuntu 24.04 #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
switch_runners_to_24.04
branch
from
e9c5ae1 to
6f2830c
Compare
anmazzotti
approved these changes
Dec 12, 2024
davidcassany
force-pushed
the
switch_runners_to_24.04
branch
19 times, most recently
from
76a62c1 to
9ffa5e7
Compare
Ubuntu 24.04 is about to the version deployed with ubuntu-latest. This commit is to start using it and validating it before the actual change happens. Signed-off-by: David Cassany <[email protected]>
Ubuntu 24.04 ships podman v4 which fixes a v3 issue on loading images. With v4 loaded images keep the image name if present. Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
switch_runners_to_24.04
branch
from
618bfc8 to
56722ea
Compare
davidcassany
commented
Dec 13, 2024
| tag=${img##*:} | ||
| imgID=$(podman images -n | grep "${tag}" | awk '{print $3}' | head -n1) | ||
| podman tag "${imgID}" "${reg_img}" | ||
| podman tag "${img}" "${reg_img}" |
Contributor
Author
There was a problem hiding this comment.
This can be simplified thanks to podman v4 included in Ubuntu 24.04. On v3 podman load was not keeping the name of the loaded image and we had to discover the new one somehow. Podman v4 addresses this behavior and keeps the original name.
davidcassany
commented
Dec 13, 2024
| if [ "${ELMNTL_DEBUG}" == "yes" ]; then | ||
| qemu-system-${ELMNTL_TARGETARCH} ${kvm_arg} ${disk_arg} ${cdrom_arg} ${global_arg} ${firmware_arg} \ | ||
| ${usrnet_arg} ${kvm_arg} ${memory_arg} ${graphics_arg} -serial stdio ${pidfile_arg} \ | ||
| ${usrnet_arg} ${memory_arg} ${graphics_arg} -serial stdio ${pidfile_arg} \ |
Contributor
Author
There was a problem hiding this comment.
kvm_arg arguments were included twice. See this is already present in the line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 24.04 is about to the version deployed with ubuntu-latest. This commit is to start using it and validating it before the actual change happens.