Accommodate 'prime-alpha' and 'prime-rc' in regex #412
Conversation
sbulage
added
fleet-e2e-ci
sbulage
changed the title
|
Above PR CI: only 3 tests failed, which are hiccup. |
|
CI for 2.12.4-alpha4 is passing: https://github.com/rancher/fleet-e2e/actions/runs/19360943874 (Failures are similar to 2.12-head CI run.) |
sbulage
force-pushed
the
update-regex-2.12
branch
from
438191a to
c6b794b
Compare
| github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= | ||
| github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= | ||
| github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA= | ||
| github.com/rancher-sandbox/ele-testhelpers v0.0.0-20251113092326-9b43cc34d982 h1:pQ0S4n8+impomKiOYBXuOGKGC6/8TV0rbFNLOhGtUFY= |
There was a problem hiding this comment.
sorry. what is the consecuence of this removal?
Shouldn't be done in other pr?
There was a problem hiding this comment.
No side effect of it, as it is just removal.
If it was addition then separate PR is required.
There was a problem hiding this comment.
Sorry, but a removal can be also problematic.
What is that removal and why is necessary?
There was a problem hiding this comment.
ok. the description has been updated to remove duplicated entry of go.sum.
Being a duplicated can be a reason to remove code, but not the removal itself, which can be dangerous.
The removal comes per my understanding from another pr trying to fix 2.12 lanes.
So that is the explanation I was looking.
Thanks approving.
There was a problem hiding this comment.
This removal is not problematic as this is extra entry for ele-testhelpes modules.
But the entry from go.mod will be used, hence removing this unnecessary entry from go.sum.
Uh oh!
There was an error while loading. Please reload this page.