[v0.11] Stable BundleDeployment modified/nonReady status #3533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruiz14
changed the title
aruiz14
force-pushed
the
stable-bd-modified-nonready-status-0.11
branch
from
1426e63 to
336d8c6
Compare
aruiz14
commented
Apr 10, 2025
| @@ -263,7 +285,11 @@ func modified(ctx context.Context, c client.Client, logger logr.Logger, plan des | |||
| return sortKey(result[i]) < sortKey(result[j]) | |||
There was a problem hiding this comment.
We need to keep sorting result, since the keys in plan's Create, Delete, Update could be different.
aruiz14
force-pushed
the
stable-bd-modified-nonready-status-0.11
branch
from
336d8c6 to
94691b1
Compare
aruiz14
added a commit
that referenced
this pull request
Apr 10, 2025
aruiz14
changed the title
manno
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #3532
While we are sorting the result of
modifiedandnonReady, since we early aborting after reaching the items limit, that subset of items could be different on every execution, ending up with an ordered subset but not idempotent results.I'm introducing the new Go iterator library to make sure we are iterating over the map inputs in order directly.