fleet cli json output #3559
Open
fleet cli json output #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
3234-json-output-fleet-cli
branch
from
1b8ba26 to
22feb32
Compare
Uses a JSONFormatter in fleet cli. It also filters out the output received from fleet cli so the error set in the conditions is only the one sent by the fleet cli code and not from any used libraries. Refers to: rancher#3234 Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
3234-json-output-fleet-cli
branch
from
22feb32 to
7ced5c9
Compare
aruiz14
reviewed
Apr 22, 2025
| @@ -3,6 +3,10 @@ package main | |||
|
|
|||
| import ( | |||
| // Ensure GVKs are registered | |||
There was a problem hiding this comment.
Please keep this comment together with the blank imports.
| Status: "True", | ||
| Reason: "BackoffLimitExceeded", | ||
| Message: "Job has reached the specified backoff limit", | ||
| Message: `{"fleetErrorMessage":"fleet error message","level":"fatal","msg":"Fleet cli failed","time":"2025-04-15T14:53:15+02:00"}`, |
There was a problem hiding this comment.
Beware that message in status conditions is by definition meant to be human-readable:
❯ kubectl explain job.status.conditions.message
GROUP: batch
KIND: Job
VERSION: v1
FIELD: message <string>
DESCRIPTION:
Human readable message indicating details about last transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a JSONFormatter in fleet cli.
It also filters out the output received from fleet cli so the error set in the conditions is only the one sent by the fleet cli code and not from any used libraries.
In order to use the json formatter we need to set the
FLEET_JSON_OUTPUTenv var totrue. This way the command line user won't get the json output unless it's explicitly specified.Refers to: #3234