[v0.13] Backport #4185 -- Use CABundle when fetching chart with helm.chart field of fleet.yaml file
#4371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml` file (rancher#4185) * Address review comments * InsecureSkipVerify for cloning git repos with fleet.yaml's helm.chart field * Refactor code duplication * Address review comments (cherry picked from commit 3ec37b2) Conflicts resolved: e2e/single-cluster/schedule_test.go e2e/testenv/githelper/git.go internal/bundlereader/loaddirectory.go
p-se
changed the title
helm.chart field of `fleet.ya…helm.chart field of fleet.yaml file
* Fix race when creating secrets and Kubernetes jobs When creating secrets and a Kubernetes Job that uses those secrets in volumes, it is possible that the job is created before the secret has been synchronized. If the job required the content of the secret to be mounted, the file would be missing. Also fixes usage of `controllerutil.CreateOrUpdate`. * Apply suggestion from @weyfonk Co-authored-by: Corentin Néau <[email protected]> --------- Co-authored-by: Corentin Néau <[email protected]> (cherry picked from commit 98965d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 3ec37b2)
Conflicts resolved:
Refers to # (TODO create if backport is supposed to be kept/merged)
Backport of #4185
Additional Information
Checklist
fleet-docs repository.