Use the defaultNs for valuesFrom contained in downstream resources #4373
+178
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a change to avoid having a "Not Found" error when using valuesFrom coming from COnfigMaps or Secrets that are also contained in the _DownstreamResources_ of the _BundleDeploymentOptions_ Refers to: rancher#4274 Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
force-pushed
the
4274-defaultns-downstream-resources-values
branch
from
8bb5c97 to
34ed31e
Compare
weyfonk
reviewed
Nov 26, 2025
Contributor
weyfonk
left a comment
weyfonk
left a comment
There was a problem hiding this comment.
Nice one, thanks! Leaving a few comments, the rest LGTM :)
Signed-off-by: Xavi Garcia <[email protected]>
weyfonk
approved these changes
Nov 27, 2025
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Nov 27, 2025
…ancher#4373) * Use the defaultNs for valuesFrom contained in downstream resources This PR adds a change to avoid having a "Not Found" error when using valuesFrom coming from COnfigMaps or Secrets that are also contained in the _DownstreamResources_ of the _BundleDeploymentOptions_ Refers to: rancher#4274 --------- Signed-off-by: Xavi Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a change to avoid having a "Not Found" error when using valuesFrom coming from COnfigMaps or Secrets that are also contained in the DownstreamResources of the BundleDeploymentOptions
Refers to: #4274
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.