Skip to content

Fleet CLI dump command filter for resources #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-se merged 21 commits into from
Feb 23, 2026
Merged

Fleet CLI dump command filter for resources #4641

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8f819fc
Filter by namespaces
p-se Feb 3, 2026
128da68
Filter by GitRepo
p-se Feb 9, 2026
ba354f8
Filter by Bundle
p-se Feb 9, 2026
c646a65
Filter by HelmOp
p-se Feb 11, 2026
e97501e
Refactor CreateWithClients
p-se Feb 12, 2026
3447ea3
Reduce cyclomatic dependency of CreateWithClients
p-se Feb 12, 2026
633e772
Fix golangci-lint issues
p-se Feb 12, 2026
d28cf5e
Filter secrets properly
p-se Feb 12, 2026
631d9cd
Fix CLI arguments
p-se Feb 12, 2026
9cdb245
Fix bundle test
p-se Feb 12, 2026
4dbb4b7
Fix possible injection into bundle names
p-se Feb 12, 2026
1d0c458
Fix issue with HelmOp filtering
p-se Feb 12, 2026
5dbc794
Remove redundant CLI argument checks
p-se Feb 12, 2026
2040cb1
Log conversion errors in ToUnstructured
p-se Feb 12, 2026
f45bf81
Fix golangci-lint issues
p-se Feb 12, 2026
f182a3d
Fix issue with helmop-template variable names
p-se Feb 12, 2026
8a08f52
Fix filtering for GitRepo, HelmOp without bundles
p-se Feb 17, 2026
a10a423
Properly close file handles
p-se Feb 17, 2026
6de4e37
Add most recent comments
p-se Feb 18, 2026
2b1b979
Don't fetch lists if filtering for a single resource
p-se Feb 18, 2026
0200fe0
Fix typo
p-se Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions e2e/assets/helmop-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ metadata:
namespace: {{.Namespace}}
spec:
helm:
chart: {{.Chart}}
repo: {{.Chart}}
chart: ""
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helmop-template.yaml sets spec.helm.repo to the OCI URL and forces spec.helm.chart to an empty string. In the Fleet API, HelmOptions.Chart is the field intended for go-getter/OCI chart URLs, while HelmOptions.Repo is for HTTPS helm repos (used together with a chart name). This template likely produces invalid HelmOps and may break e2e HelmOp creation. Set spec.helm.chart to {{.Chart}} (and omit/empty repo) for OCI usage.

Suggested change
repo: {{.Chart}}
chart: ""
repo: ""
chart: {{.Chart}}

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@p-se p-se Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true, the documentation clearly states, that for OCI URLs the repo field is the one to be used. However, using a Chart variable in the repo field is clearly confusing.

version: {{.Version}}
namespace: {{.Namespace}}
namespace: {{.Namespace}}
targets:
- clusterSelector: {}
Loading
Loading