Skip to content

Make sure Renovate updates integrations/go.mod#4774

Open
thardeck wants to merge 2 commits intomainfrom
let_renovate_update_all_go.mods
Open

Make sure Renovate updates integrations/go.mod#4774
thardeck wants to merge 2 commits intomainfrom
let_renovate_update_all_go.mods

Conversation

@thardeck
Copy link
Collaborator

@thardeck thardeck commented Mar 9, 2026

to prevent issues that it is not bumped by Renovate while go mod tidy would update it.

Also adjust the rule to only participates in updates when the same dependency is already being updated elsewhere in the workspace to prevent unwanted indirect update prs.

@thardeck thardeck self-assigned this Mar 9, 2026
@thardeck thardeck added this to Fleet Mar 9, 2026
@thardeck thardeck requested a review from a team as a code owner March 9, 2026 07:42
Copilot AI review requested due to automatic review settings March 9, 2026 07:42
@thardeck thardeck moved this to 👀 In review in Fleet Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Renovate configuration to better handle dependency updates for Go workspace (go.work) child modules, aiming to prevent go mod tidy from changing child go.mod files that Renovate didn’t update.

Changes:

  • Adds a Renovate packageRules entry targeting indirect (// indirect) Go module dependencies.
  • Applies that rule specifically to integrationtests/go.mod and pkg/apis/go.mod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thardeck thardeck force-pushed the let_renovate_update_all_go.mods branch from 2d3273c to 68b02ba Compare March 9, 2026 09:24
@thardeck thardeck changed the title Make sure Renovate updates all go.mod files Make sure Renovate updates integrations/go.mod Mar 9, 2026
@thardeck thardeck requested a review from weyfonk March 9, 2026 09:28
to prevent issues that it is not bumped by Renovate while `go mod tidy`
would update it.

Also adjust the rule to only participates in updates when the same
dependency is already being updated elsewhere in the workspace to
prevent unwanted indirect update prs.
@thardeck thardeck force-pushed the let_renovate_update_all_go.mods branch from 68b02ba to 7eb2d74 Compare March 9, 2026 10:11
@thardeck thardeck requested a review from weyfonk March 9, 2026 10:13
@thardeck
Copy link
Collaborator Author

thardeck commented Mar 9, 2026

I have let renovate run with the new fix and it did not create any new pull requests. But we can leave this open until a new bump is there which has this issue to retry.

@thardeck thardeck moved this from 👀 In review to Blocked in Fleet Mar 13, 2026
@thardeck
Copy link
Collaborator Author

Blocked until we can test it with a Renovate pr which has the described issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

4 participants