Return cli List error closer to where was returned#4822
Merged
Conversation
When looking for a different issue I found this code that confused me. In case List returns an error we're still trying to iterate the returned list (that should be empty, we cannot guarantee) This PR returns the error earlier and avoids accessing the list, that in future implementations of List could be returning nil and make this panic. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the CLI apply pruning logic to stop processing bundles when the initial bundle list operation fails, preventing iteration over potentially invalid results and aligning behavior with the intended error handling described in the PR.
Changes:
- Return immediately if
c.List(...)fails inpruneBundlesNotFoundInRepoto avoid iterating overbundleList.Itemson error. - Simplify delete error handling by inlining the
c.Delete(...)error check. - Return
nilexplicitly at the end of the prune function instead of propagating a staleerr.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
thardeck
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking for a different issue I found this code that confused me. In case List returns an error we're still trying to iterate the returned list (that should be empty, we cannot guarantee) This PR returns the error earlier and avoids accessing the list, that in future implementations of List could be returning nil and make this panic.
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.