fix: honor insecureSkipTLS in OCI storage secret#4890
Merged
Conversation
khushalchandak17
force-pushed
the
fix-insecure-oci
branch
from
738ffcd to
7c8645a
Compare
…is helper. Co-authored-by: Corentin Néau <tan.neau@suse.com>
khushalchandak17
added a commit
to khushalchandak17/fleet
that referenced
this pull request
Apr 1, 2026
Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. Co-authored-by: Corentin Néau <tan.neau@suse.com> (cherry picked from commit 3951853)
khushalchandak17
added a commit
to khushalchandak17/fleet
that referenced
this pull request
Apr 1, 2026
Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. Co-authored-by: Corentin Néau <tan.neau@suse.com> (cherry picked from commit 3951853)
khushalchandak17
added a commit
to khushalchandak17/fleet
that referenced
this pull request
Apr 1, 2026
Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. Co-authored-by: Corentin Néau <tan.neau@suse.com> (cherry picked from commit 3951853)
thardeck
pushed a commit
that referenced
this pull request
Apr 7, 2026
Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. (cherry picked from commit 3951853) Co-authored-by: Corentin Néau <tan.neau@suse.com>
khushalchandak17
added a commit
to khushalchandak17/fleet
that referenced
this pull request
Apr 7, 2026
Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. Co-authored-by: Corentin Néau <tan.neau@suse.com> (cherry picked from commit 3951853)
thardeck
pushed a commit
that referenced
this pull request
Apr 7, 2026
…4925) * fix: honor insecureSkipTLS in OCI storage secret (#4890) Fleet currently reads the legacy `insecure` field from the OCI storage secret. If the secret is created with `insecureSkipTLS: true`, that value is not recognized, so Fleet agents still perform TLS verification and may fail against registries using a self-signed/private CA. This change: - prefers `insecureSkipTLS` - keeps `insecure` as a backward-compatible fallback - updates test coverage to use `insecureSkipTLS` This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy `insecure` field. Co-authored-by: Corentin Néau <tan.neau@suse.com> (cherry picked from commit 3951853) * test: add OCI insecureSkipTLS apply regression --------- Co-authored-by: Corentin Néau <tan.neau@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #4898
This PR fixes OCI storage secret parsing to honor
insecureSkipTLS.Fleet currently reads the legacy
insecurefield from the OCI storage secret. If the secret is created withinsecureSkipTLS: true, that value is not recognized, so downstreamfleet-agentstill performs TLS verification and may fail against registries using a self-signed/private CA.This change:
insecureSkipTLSinsecureas a backward-compatible fallbackinsecureSkipTLSAdditional Information
This is intended to be a minimal fix for OCI storage secret parsing and avoids breaking existing setups that may still use the legacy
insecurefield.