bundlereader: merge PROXY_CA_BUNDLE into CABundle for HTTPS git clones#4919
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates bundlereader’s go-git clone path to trust custom HTTPS proxy CAs by merging PROXY_CA_BUNDLE into the effective CA bundle passed to go-git, aligning helm.chart git downloads with existing proxy CA support elsewhere in the codebase.
Changes:
- Append
PROXY_CA_BUNDLEtoauth.CABundle(via a defensive copy) before setting go-gitCloneOptions.CABundle. - Expand/clarify
gitDownloadTLS/proxy behavior documentation. - Add unit tests covering
PROXY_CA_BUNDLE-only and merged CA bundle scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/bundlereader/gitclone.go | Merges PROXY_CA_BUNDLE into the CA bundle passed to go-git clone options. |
| internal/bundlereader/gitclone_test.go | Adds tests verifying PROXY_CA_BUNDLE merge behavior during TLS verification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gitDownload now appends PROXY_CA_BUNDLE to auth.CABundle before passing the combined PEM to go-git's CloneOptions.CABundle, so that git::https:// repos cloned through an HTTPS proxy with a custom CA certificate are trusted. A defensive copy of auth.CABundle is made to avoid mutating the caller's slice.
thardeck
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitDownload now appends PROXY_CA_BUNDLE to auth.CABundle before passing the combined PEM to go-git's CloneOptions.CABundle, so that git::https:// repos cloned through an HTTPS proxy with a custom CA certificate are trusted. A defensive copy of auth.CABundle is made to avoid mutating the caller's slice.
Refers to #4869
Additional Information
Checklist