[v1.32] update CI for rke extended life #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/release.yaml
Outdated
| echo "IMAGE=${STAGE_REGISTRY_ENDPOINT}/rke-extended-life/hyperkube" >> "$GITHUB_ENV" | ||
| - name: Logout from Docker registry | ||
| run: docker logout ${{ env.REGISTRY_ENDPOINT }} || true | ||
| run: docker logout ${{ env.STAGE_REGISTRY_ENDPOINT }} || true |
There was a problem hiding this comment.
why do we need to logout?
the runners are supposed to be single use, so there should be no need for this afaik..
There was a problem hiding this comment.
also we have https://github.com/docker/login-action?tab=readme-ov-file#inputs logout option with that in case we need to do that..
Member
Author
There was a problem hiding this comment.
Added it earlier to fix issues with login based on EIO team's suggestion. Will remove, no longer required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.