[SURE-8459]fix: remove system-default-registry flag from k3s and rke2 #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikjagrut
changed the title
Member
|
hi @pratikjagrut, thank you for raising the fix. I need to confirm with the team on whether we could modify the template for the released rke2/k3s versions. |
Member
|
btw, you need to run |
Author
Thank you @jiaqiluo. I just did and pushed the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--system-default-registryflag was removed from the rke2/k3s agent in this PR. However, it is still part of KDM, which is causing issues as noted in this issue.