Fix missing RBAC for canal > v2.39.0 #1698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RBAC of canal has been expanded in the latest releases and this hadn't been mirrored in the template files, which resulted in the calico-kube-controller pod throwing multiple warnings, because it couldn't list the "kubecontrollersconfigurations" at the cluster scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Should fix rancher/rancher#50568
Changes
Just added the missing list verb to the clusterrole for v2.39 and ran go generate.
Tests done
I haven't tested this myself as we're running an air-gapped rancher installation and it is a bit tricky getting a new kontainer-metadata in the rancher pods, without rebuilding rancher I guess? The generated content looks OK though :)