-
Notifications
You must be signed in to change notification settings - Fork 127
[v2.12] add prime mode logic to the provisioning-tests script #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-v2.12
Are you sure you want to change the base?
[v2.12] add prime mode logic to the provisioning-tests script #1838
Conversation
|
Green run with prime test from this commit ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Prime mode detection logic to the KDM provisioning test scripts for the v2.12 branch. It enables the test infrastructure to automatically detect when a selected Kubernetes version requires Prime registry access and configure the appropriate staging or production Prime registry endpoints.
Key changes:
- Adds version comparison and channel parsing utilities to detect Prime-only Kubernetes versions
- Implements Prime registry selection logic (staging for RC versions, production for stable)
- Adds early validation to fail with clear error messages when Prime is required but registry endpoints are unavailable
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/semver_g.awk | New AWK script for semantic version comparison (ignoring pre-release suffixes) |
| scripts/channels-pick-minchan-for-version.awk | New AWK script to extract minChannelServerVersion from channels file |
| scripts/prime-route | New shell script that implements Prime mode detection and registry configuration logic |
| scripts/provisioning-tests | Integrates Prime mode detection with early validation for missing registry endpoints |
| .github/workflows/provisioning-tests.yaml | Adds vault secret retrieval for Prime registries and sets Prime configuration environment variables |
| Dockerfile.dapper | Passes Prime-related environment variables through to Dapper container |
| docs/release.md | Documents Prime configuration variables and usage guidelines for release management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eb3348f to
ae7b6a4
Compare
ae7b6a4 to
0a6798a
Compare
Issue #51881
Prepare KDM CI and test scripts to work when KDM marks Prime-only Kubernetes versions. Same idea as PR #1822 for v2.9, adapted per branch.
Problem
KDM CI and test scripts needs to:
Solution
Prime detection in scripts:
Early guard:
Defaults and safety:
Workflow integration: