Update f5/nginx-ingress icon, and update README.md with info on how to update a chart's icon
#1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troytop
approved these changes
Apr 25, 2025
Contributor
troytop
left a comment
troytop
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
recena
reviewed
Apr 25, 2025
| is useful for this; for more information please see the | ||
| [`partner-charts-ci` documentation](https://github.com/rancher/partner-charts-ci?tab=readme-ov-file#4-run-partner-charts-ci-update). | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
This empty line is not needed.
Collaborator
Author
There was a problem hiding this comment.
The readme currently has two empty lines after each section. I like doing it this way because it makes the file easier to read in a text editor. I can change this if you want, but it doesn't have any effect on the HTML version of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the icon in a development version of Rancher and it looked good. I'd post a screenshot but it seems my screenshot utility is broken.