-
Notifications
You must be signed in to change notification settings - Fork 194
Updating Kasten logo to new Veeam Kasten logo and changing product na… #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| HelmRepo: https://charts.kasten.io | ||
| HelmChart: k10 | ||
| Vendor: Kasten | ||
| DisplayName: K10 | ||
| Vendor: Veeam | ||
| DisplayName: Kasten | ||
| PackageVersion: 01 | ||
| Fetch: newer | ||
| ChartMetadata: | ||
| kubeVersion: '>= 1.17.0-0' | ||
| icon: https://docs.kasten.io/_static/logo-kasten-k10-blue-white.png | ||
| icon: https://kastenmarketplace.s3.us-west-2.amazonaws.com/veeam-kasten-logo-square_white_bg.png | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @slotdawg, it is good to set this here. However, when
bin/partner-charts-ci updateruns, it does not update the icon if it finds one at theassets/icons/k10.png. This file exists, so the icon will not be updated with only these changes.Please update
assets/icons/k10.pngin this PR with the one you want to use - that will make existing and future versions of this chart use the proper icon. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the whole chart needs to be moved from kasten/k10 to veeam/kasten. @slotdawg would this be more correct with the new branding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@troytop it would be more correct with the new branding, however our helm chart still uses the "k10" moniker (i.e. k10-8.0.0 is our latest chart and it's referred to as kasten/k10 in our documentation). So long story short, unless you guys disagree, I think we should keep the chart/folder structure as-is to align with "k10" in the product itself, versus "veeam kasten" for the branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me to leave it where it is. As @adamkpickering says though, we'll need you to update
assets/icons/k10.png