Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icons/k10.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions packages/kasten/k10/upstream.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
HelmRepo: https://charts.kasten.io
HelmChart: k10
Vendor: Kasten
DisplayName: K10
Vendor: Veeam
DisplayName: Kasten
PackageVersion: 01
Fetch: newer
ChartMetadata:
kubeVersion: '>= 1.17.0-0'
icon: https://docs.kasten.io/_static/logo-kasten-k10-blue-white.png
icon: https://kastenmarketplace.s3.us-west-2.amazonaws.com/veeam-kasten-logo-square_white_bg.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slotdawg, it is good to set this here. However, when bin/partner-charts-ci update runs, it does not update the icon if it finds one at the assets/icons/k10.png. This file exists, so the icon will not be updated with only these changes.

Please update assets/icons/k10.png in this PR with the one you want to use - that will make existing and future versions of this chart use the proper icon. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the whole chart needs to be moved from kasten/k10 to veeam/kasten. @slotdawg would this be more correct with the new branding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troytop it would be more correct with the new branding, however our helm chart still uses the "k10" moniker (i.e. k10-8.0.0 is our latest chart and it's referred to as kasten/k10 in our documentation). So long story short, unless you guys disagree, I think we should keep the chart/folder structure as-is to align with "k10" in the product itself, versus "veeam kasten" for the branding.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me to leave it where it is. As @adamkpickering says though, we'll need you to update assets/icons/k10.png