Adding NetScaler remaining Helm Charts to Rancher #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netscaler/netscaler-gslb-controller:
- 3.2.22
netscaler/netscaler-ipam-controller:
- 2.1.2
netscaler/netscaler-kubernetes-gateway-controller:
- 1.2.0
netscaler/netscaler-node-controller:
- 2.2.15
netscaler/netscaler-observability-exporter:
- 1.10.001
Contributor
|
It may be a couple of weeks before we can get a review on this. Please send us an email at [email protected] to discuss renewing the partner certification for NetScaler. |
adamkpickering
requested changes
Sep 30, 2025
Collaborator
adamkpickering
left a comment
adamkpickering
left a comment
There was a problem hiding this comment.
Just one comment on a couple of typos in a readme. Otherwise LGTM.
| @@ -0,0 +1,5 @@ | |||
| # NetScaler GSLB Controller | |||
|
|
|||
| [NetScaler GSLB Controller](https://docs.netscaler.com/en-us/netscaler-k8s-ingress-controller/gslb/gslb) globally monitors applications, collect, and share metrics across different clusters, and provides intelligent load balancing decisions. It ensures better performance and reliability for your Kubernetes applications.NetScaler GSLB Controller is the module responsible for the configuration of the NetScaler GSLB devices. | |||
Collaborator
There was a problem hiding this comment.
Looks like there are two typos here:
- A double space (see
gslb/gslb) globally monitors applications) - A missing space (see
your Kubernetes applications.NetScaler GSLB Controller)
Grammar in the first sentence could be improved as well, specifically around "collect".
Don't forget to delete the changes from charts/ and assets/ and re-run bin/partner-charts-ci update after you make this change. This ensures that your updates from the packages/ directory are propagated to the actual helm charts that users will use.
Contributor
Author
|
Fixed review comments and ran the scripts also: |
netscaler/netscaler-gslb-controller:
- 3.2.22
adamkpickering
requested changes
Oct 6, 2025
packages/netscaler/netscaler-gslb-controller/overlay/app-readme.md
Outdated
Show resolved
Hide resolved
netscaler/netscaler-gslb-controller:
- 3.2.22
Contributor
Author
|
Hi @adamkpickering , Changes are done. Thanks for the review. |
adamkpickering
approved these changes
Oct 7, 2025
Collaborator
|
j-travis
pushed a commit
to kasmtech/partner-charts
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.