feat: add config.nodeName to joiner #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when we create the first node, we can give the customized node name (
config.noddeName
) here.rancherd/pkg/resources/resources.go
Lines 54 to 62 in 6f7255e
But, for the joiner, we don't have a chance to give the
config.nodeName
to it.rancherd/pkg/join/join.go
Lines 49 to 62 in 6f7255e
Solution
Add new env
CATTLE_NODE_NAME
for the joiner ifconfig.nodeName
is set.Related Issue
harvester/harvester#7312