Skip to content

Bump go to 1.25 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
crobby wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bump go to 1.25 #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/fakek8s/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24 as builder
FROM golang:1.25 as builder
WORKDIR /app
COPY . .
RUN go mod download
Expand Down
2 changes: 1 addition & 1 deletion examples/fakek8s/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module dummy/fakek8s

go 1.24
go 1.25
4 changes: 3 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/rancher/remotedialer

go 1.24.0
go 1.25

toolchain go1.25.4
Copy link
Member

@brandond brandond Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't bump the required go version in go.mod unless the project actually needs some feature from go1.25. We still need to use remotedialer in versions of k3s and rke2 that are locked to 1.24 by Kubernetes. Leaving go.mod on go1.24 does not prevent building it with 1.25.


require (
github.com/gorilla/mux v1.8.1
Expand Down