[v1.8] upload rke extended images list on tag #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinarashah
force-pushed
the
rke-extended-life-images
branch
from
7aa595b to
82f70f6
Compare
jakefhyde
requested changes
Sep 25, 2025
scripts/create-imageslist.sh
Outdated
| ./bin/rke config --system-images --all | grep -Eo '^[^ ]+/.+' | grep -v '^noiro/' | sort | uniq > "$IMAGES_LIST_FILE" | ||
|
|
||
| # Check if the command was successful | ||
| if [ $? -ne 0 ]; then |
Contributor
There was a problem hiding this comment.
Won't set -e cause the above command to exit anyway?
Member
Author
There was a problem hiding this comment.
Yep, looks redundant with set -e in the beginning. Picked the template from https://github.com/rancher/rke/pull/2843/files#diff-711d44b1e728c3a61cf4123cc4ccd56bdeadb212c8faf443913b3d72ccd0305a. Removed this check
kinarashah
force-pushed
the
rke-extended-life-images
branch
from
82f70f6 to
65f602d
Compare
jakefhyde
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts under build/bin are already uploaded as artifacts: https://github.com/rancher/rke/blob/release/v1.8/.github/workflows/workflow.yaml#L109
https://github.com/rancher/rke/blob/release/v1.8/.github/workflows/workflow.yaml#L130
Creating new file rke-extended-life-images.txt to avoid uploading it manually. See https://github.com/rancher/rke/releases/download/v1.8.7/rke-extended-life-images.txt for reference.