Added autogenerated PSK field and change type to Secret #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry, I totally missed this PR! Note that we are basically consuming upstream canal with really minor differences. This PR will increase those differences and thus I wonder if you could first contribute these changes to the upstream project and then we can incorporate them here, otherwise maintenance might become difficult |
Author
|
Can surely do, could you point me to the correct repo? |
Contributor
Yes! https://github.com/projectcalico/calico/tree/master/calico/_includes/charts/calico. Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in the flannel docs the ipsec variant needs to have a pre-shared key.
Also related to rancher/image-build-flannel#7