Bootstrap docs for otel mappings troubleshooting #140
Conversation
✅ Deploy Preview for suse-obs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| start_page: en:classic.adoc | ||
| asciidoc: | ||
| attributes: | ||
| stackpacks2_enabled: false |
There was a problem hiding this comment.
is there now a deploy where this is enabled? should we get that going?
There was a problem hiding this comment.
No, there's no deployment with that enabled. @akashraj4261 explained to us that we could flip it for the review so we can see it in the 😎 Deploy Preview
There was a problem hiding this comment.
i would be great if DeployPreview would enable the flag but our production deploy does not, lets ask him during standup
There was a problem hiding this comment.
I see netlify uses the ss-local-playbook to render the netlify deploy. (https://app.netlify.com/projects/suse-obs/deploys/69285d3149b414000837bf17)
Can we not add the attribute to true to that file and leave it out of the ss-remote-playbook (which i assume is used for production).
@akashraj4261 please advise
| ifdef::stackpacks2_enabled[] | ||
| ** xref:setup/otel/otelmappings/README.adoc[Open Telemetry Mappings] | ||
| *** xref:setup/otel/otelmappings/concepts.adoc[Concepts] | ||
| *** xref:setup/otel/otelmappings/troubleshooting.adoc[Troubleshooting] |
There was a problem hiding this comment.
i can still find this page through search, any chance we can feature flag all the pages? https://deploy-preview-140--suse-obs.netlify.app/suse-observability/latest/en/setup/otel/otelmappings/troubleshooting.html
There was a problem hiding this comment.
I can feature flag the whole page with a similar ifdef block but we discussed that's it's an overkill. Same if you would like to guard the case where somebody knows/gets the url
There was a problem hiding this comment.
@rb3ckers what is your thought here. are we ok having these pages show up in live docs during search and if the URLs are known?
There was a problem hiding this comment.
Seems that feature flagging each page will help with the search ..
There was a problem hiding this comment.
I prefer not to have them in the search. But having the url be accessible is ok I think. If people are guessing URLs I wouldn't mind too much.
There was a problem hiding this comment.
Then I think the latest changes accomplish that .... not available in the search
docs/latest/modules/en/pages/setup/otel/otelmappings/troubleshooting.adoc
Show resolved
Hide resolved
docs/latest/modules/en/pages/setup/otel/otelmappings/troubleshooting.adoc
Show resolved
Hide resolved
4 participants
No description provided.