Replace push:tags release trigger with validated workflow_dispatch#1159
Open
tomleb wants to merge 3 commits intorancher:mainfrom
Open
Replace push:tags release trigger with validated workflow_dispatch#1159tomleb wants to merge 3 commits intorancher:mainfrom
tomleb wants to merge 3 commits intorancher:mainfrom
Conversation
tomleb
force-pushed
the
validate-release-main
branch
from
dc97a82 to
dbf6959
Compare
Replaces the existing `on: push: tags: v*` trigger with a `workflow_dispatch` workflow that validates the version before creating the tag and GitHub release. The validate job checks version format, confirms the version prefix matches the branch's allowed minor (read from VERSION.md on the default branch), enforces sequential patch ordering, and confirms the tag does not already exist. The release job then creates and pushes the annotated tag before creating the GitHub release.
tomleb
force-pushed
the
validate-release-main
branch
from
dbf6959 to
609ab9e
Compare
24 tasks
- Use non-capturing group in version regex - Replace awk with grep/cut/tr for VERSION.md parsing
bash ERE does not support (?:...) — revert to capturing group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue rancher/rancher#54790
Replace the
on: push: tags: v*trigger with aworkflow_dispatchworkflow that validates the version before creating the tag and GitHub release.The
validatejob:v<major>.<minor>.<patch>[-prerelease])VERSION.mdon the default branch)The
releasejob (runs aftervalidate):