VAI: Create fields and other info for new database tables only when needed #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ancher#919) * Extract the code for setting up an integration test with real objects. * Add an e2e test for verifying namespace/mcio.project relations work. * test secrets and some refactoring * Bring in the e2e secret tests. Refactoring and commenting: - Use more explicit constant/variable names - Add comments on expected sorted values to show why we expect a particular ordering - Arrange equivalent things (functions, parallel assignments) in alpha order. * Fix/improve error messages in object transformers. * Wait for the objects we create.
ericpromislow
force-pushed
the
52776-func-based-create-fields-when-needed
branch
from
a49522b to
aad4079
Compare
Wrap the field-calculator in a closure, and pass it to the informer, to be invoked only when it needs to create db tables.
ericpromislow
force-pushed
the
52776-func-based-create-fields-when-needed
branch
from
aad4079 to
b215d7b
Compare
ericpromislow
changed the title
ericpromislow
changed the title
crobby
reviewed
Nov 21, 2025
pkg/sqlcache/integration_test.go
Outdated
|
|
||
| // Comment out the 'ignore' in the function name to run it. Useful only for comparing running | ||
| // times across different branches | ||
| func (i *IntegrationSuite) ignoreTestNamespaceProjectDependenciesWithPseudoBenchmarks() { |
Contributor
There was a problem hiding this comment.
instead of using the "ignore" paradigm, could we use t.Skip unless an ENV var of some sort is set?
gehrkefc
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #52776
I include an ignored pseudo-benchmark test. When I call
proxyStore.ListByPartitions100 times with live data, I get the following scores locally:MAIN: 52 msecs
This PR: 43 msecs
So a drop of about 20%. Running the full steve test suite saw a drop of about 30%:
Over 10 runs, avg run time:
MAIN: 3.20 secs
PR: 2.08 secs
Drop of about 35% running the test suite.