fix flaky integration test #937
Open
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a bit of a delay between when a project is created and when these values exist. This is more likely to show up in CI than locally, sure sounds like a timing issue. Final cleanup
ericpromislow
force-pushed
the
52864-fix-flaky-integration-test
branch
from
bfbb6d5 to
bceb235
Compare
gehrkefc
reviewed
Nov 26, 2025
pkg/sqlcache/integration_test.go
Outdated
Comment on lines
555
to
556
| // note that we don't return the error since that would stop the polling | ||
| return false, err |
gehrkefc
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #52864
Try to fix a flaky CI test
The problem is that these integration tests depend on a field (spec.clusterName or spec.displayName)
getting copied from mcio.projects to either _v1_secret or _v1_namespace. It seems that sometimes
there's a delay between when the project is created and when accessing it pulls down the full value.
This makes sense -- much of kubernetes is async and distributed. So we wait a bit.