Fix missing default column name and age for CRDs #941
+505
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
commented
Nov 27, 2025
| - [bar, foo, $skip, $duration] | ||
| - schemaID: timestamps.cattle.io.dates | ||
| expected: | ||
| - [the-date, $duration, $duration, $duration, $timestamp, $duration, $timestamp] |
Contributor
Author
There was a problem hiding this comment.
The $timestamp ones are because the type is a string for those columns
Contributor
Author
|
Seems like this also results in some issues where sorting doesn't work on fields from CRDs 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue rancher/rancher#52780
Unfortunately, we cannot get rid of those columns yet for two reasons:
Agecolumn. So instead of showing a pretty printed date, we getInvalid Datecolumn shown. Fixing that involves a bigger change (sending a timestamp instead of duration to the UI which I'm not willing to make from the little time we have before 2.13.1.So the fix here is adding the missing default columns and calling it a day for now. This PR adds a bunch of tests to try and cover as much as possible so that next time we do make changes, we'll know about regressions and what changes.