Fix systemd unit file umask handling in install.sh #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #244
Problem
PR #245 changed the installer to adjust the umask and run "chmod 0644" after creating the systemd unit file. The goal was to avoid the systemd warning:
"Configuration file /etc/systemd/system/rancher-system-agent.service is marked world-inaccessible."
However, the "chmod" and umask restore lines were placed inside the here-doc. This caused two problems reported by @pedromfcarvalho:
Solution
Testing
Engineering Testing
Manual Testing
On a Ubuntu node on DigitalOcean: