feat: add reserved memory field#1510
Conversation
FrankYang0529
force-pushed
the
HARV-5764
branch
3 times, most recently
from
80e5a97 to
13bf428
Compare
FrankYang0529
changed the title
m-ildefons
left a comment
m-ildefons
left a comment
There was a problem hiding this comment.
I think there is a mixup in rancher2/structure_machine_config_v2_harvester.go
| obj["memory_size"] = in.MemorySize | ||
| } | ||
|
|
||
| if len(in.DiskSize) > 0 { |
There was a problem hiding this comment.
Did you mean len(in.ReservedMemorySize) > 0?
There was a problem hiding this comment.
You're correct. Updated it. Thanks.
matttrach
left a comment
matttrach
left a comment
There was a problem hiding this comment.
This change looks good from a Terraform perspective.
How was it tested?
matttrach
added
area/harvester
release/v8
|
What version of Rancher or the provider is this targeting? |
|
Ignore the validate commit message error, it is from the branch update. |
|
@matttrach Thanks for the review. We may not merge it now. It's waiting for harvester/docker-machine-driver-harvester#75 and updating related driver in Rancher. |
|
Wait for PR rancher/rancher#51078. |
FrankYang0529
force-pushed
the
HARV-5764
branch
from
b5c167c to
3bbb8e9
Compare
|
What release versions is this targeting? |
matttrach
removed
the
release/v8
|
@matttrach Sorry for the late reply. This PR can work for Rancher version >= v2.12.0. |
FrankYang0529
force-pushed
the
HARV-5764
branch
from
3e0b220 to
4f6652b
Compare
FrankYang0529
force-pushed
the
HARV-5764
branch
from
4f6652b to
e7aaea5
Compare
Signed-off-by: PoAn Yang <poan.yang@suse.com>
FrankYang0529
force-pushed
the
HARV-5764
branch
from
e7aaea5 to
7cac260
Compare
|
friendly ping @matttrach |
matttrach
added
release/v13
Signed-off-by: PoAn Yang <poan.yang@suse.com> (cherry picked from commit c1b4fa0)
Signed-off-by: PoAn Yang <poan.yang@suse.com> (cherry picked from commit c1b4fa0)
|
#1813 is now tracking the release of this PR |
4 participants
Issue: harvester/harvester#5764
Solution
Add reserved memory field.
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations