feat: Implement support for GCE machine configs#1517
Merged
Conversation
Collaborator
|
Please make sure that your commit messages fit this convention before merge: |
c1db4d8 to
6ec6aa7
Compare
Collaborator
Author
|
Thanks for the link! Both the title and commit should be correct now. |
matttrach
approved these changes
May 30, 2025
Collaborator
matttrach
left a comment
There was a problem hiding this comment.
This looks good to me
Collaborator
|
created #1533 to track progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#49681
Problem
Rancher v2.12.0 will add support for a Google Compute Engine node driver, however the associated machine config is not supported in the provider.
Solution
Add support for the GCE machine config, allowing users to provision GCE clusters using the terraform provider.
Testing
I've tested these changes against a Rancher version which allows for the provisioning of GCE clusters. I was able to successfully provision and destroy a simple GCE cluster which exposes ports publicly, creates an internal network, and applies custom labels and tags.
Engineering Testing
Manual Testing
I've done the above
Automated Testing
n/a
QA Testing Considerations
Some fields shouldn't be set when testing
auth_encoded_jsonshould be omitted, and instead cloud credentials should be used to provide this information.use_existingshould be omitted, as Rancher node drivers do not support importing existing nodesWhile these fields should not be used, I added them to the config so that it fully represents the actual machine config CR. I'm open to removing them, but similar fields exist in other machine configs offered by the provider and I wanted to follow the established pattern.
Regressions Considerations
n/a, as this PR follows the established pattern of other machine configs in the provider.