Skip to content

feat: Implement support for GCE machine configs#1517

Merged
matttrach merged 2 commits into
rancher:masterfrom
HarrisonWAffel:gce
Jun 9, 2025
Merged

feat: Implement support for GCE machine configs#1517
matttrach merged 2 commits into
rancher:masterfrom
HarrisonWAffel:gce

Conversation

@HarrisonWAffel
Copy link
Copy Markdown
Collaborator

@HarrisonWAffel HarrisonWAffel commented May 28, 2025

Issue: rancher/rancher#49681

Problem

Rancher v2.12.0 will add support for a Google Compute Engine node driver, however the associated machine config is not supported in the provider.

Solution

Add support for the GCE machine config, allowing users to provision GCE clusters using the terraform provider.

Testing

I've tested these changes against a Rancher version which allows for the provisioning of GCE clusters. I was able to successfully provision and destroy a simple GCE cluster which exposes ports publicly, creates an internal network, and applies custom labels and tags.

Engineering Testing

Manual Testing

I've done the above

Automated Testing

n/a

QA Testing Considerations

Some fields shouldn't be set when testing

  • auth_encoded_json should be omitted, and instead cloud credentials should be used to provide this information.
  • use_existing should be omitted, as Rancher node drivers do not support importing existing nodes

While these fields should not be used, I added them to the config so that it fully represents the actual machine config CR. I'm open to removing them, but similar fields exist in other machine configs offered by the provider and I wanted to follow the established pattern.

Regressions Considerations

n/a, as this PR follows the established pattern of other machine configs in the provider.

@matttrach
Copy link
Copy Markdown
Collaborator

Please make sure that your commit messages fit this convention before merge:
https://github.com/googleapis/release-please?tab=readme-ov-file#how-should-i-write-my-commits

@HarrisonWAffel HarrisonWAffel changed the title Implement support for GCE machine configs feat: Implement support for GCE machine configs May 28, 2025
@HarrisonWAffel HarrisonWAffel force-pushed the gce branch 2 times, most recently from c1db4d8 to 6ec6aa7 Compare May 28, 2025 21:28
@HarrisonWAffel HarrisonWAffel marked this pull request as ready for review May 28, 2025 21:30
@HarrisonWAffel
Copy link
Copy Markdown
Collaborator Author

Thanks for the link! Both the title and commit should be correct now.

Copy link
Copy Markdown
Collaborator

@matttrach matttrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@matttrach matttrach added area/provisioning release/v8 Release with v8.x correlating to Rancher's v2.12.x labels May 30, 2025
@matttrach matttrach added this to the July Release milestone May 30, 2025
@matttrach matttrach self-assigned this Jun 9, 2025
@matttrach matttrach merged commit 6a2e4e6 into rancher:master Jun 9, 2025
5 of 6 checks passed
@matttrach
Copy link
Copy Markdown
Collaborator

created #1533 to track progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/v8 Release with v8.x correlating to Rancher's v2.12.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants