feat: Support OIDC Provider OIDC Clients#2147
Open
bigkevmcd wants to merge 1 commit into
Open
Conversation
8c8fa7f to
7e15537
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Terraform resource to manage Rancher OIDC clients (CRUD) and registers it with the provider.
Changes:
- Introduces
rancher2_oidc_clientresource implementation (schema + CRUD). - Adds unit tests for expand/flatten helpers.
- Registers the new resource in
Provider()resources map.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
rancher2/resource_rancher2_oidc_client.go |
New OIDC client resource schema + CRUD + expand/flatten helpers. |
rancher2/resource_rancher2_oidc_client_test.go |
Unit tests for expand/flatten behavior. |
rancher2/provider.go |
Registers the new rancher2_oidc_client resource. |
This was referenced Apr 24, 2026
7e15537 to
7b87e5c
Compare
7b87e5c to
4d388e7
Compare
4d388e7 to
dee3e92
Compare
dee3e92 to
478a5ef
Compare
367aae4 to
ed00cc1
Compare
2c5d726 to
c57b5bb
Compare
c57b5bb to
52dff94
Compare
fb5d2b4 to
52dff94
Compare
JonCrowther
reviewed
May 15, 2026
Contributor
JonCrowther
left a comment
There was a problem hiding this comment.
LGTM with just one nit related to the logging
140e5f0 to
493535e
Compare
This adds support for the OIDC Provider OIDCClient resource.
493535e to
5367660
Compare
JonCrowther
approved these changes
May 26, 2026
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2156 and rancher/rancher#53639
Description
Adds support for CRUDding OIDCClients
Testing
Not a breaking change.