fix: separate install from bootstrap#134
Merged
Merged
Conversation
Signed-off-by: matttrach <matt.trachier@suse.com>
Signed-off-by: matttrach <matt.trachier@suse.com>
Signed-off-by: matttrach <matt.trachier@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change separates out the Rancher bootstrap code from the Helm install code.
The goal is to enable a use case where the Rancher provider isn't instantiated in this module.
We will use this to test alternative bootstrapping techniques and Rancher provider instantiation in the provider project.
I added a new example to cover and test this use case called "dev".
This also makes the acme_server_url an explicit variable to all of the examples, because I was having trouble setting it from the environment.
This also separates out the part of the run_test script which cleans up into its own file.
The new cleanup script is more comprehensive and able to be run by itself.