fix: add cloud credentials for downstream deploy#160
Merged
Conversation
Signed-off-by: matttrach <matt.trachier@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the patch to add our temp AWS credentials to the machine config is now being overridden by the credential management system, or at least the lack of credentials in the credential management system is causing problems.
This change adds a cloud credential using our temp SSO credentials while still setting the session token in the machine config to get all of the temp credentials in place (albeit from two different places).
It also reduces the node config name which doubles up the cluster name because it was getting very close to the 65 character limit.