fix: replace wait with a test for Rancher#89
Merged
Conversation
Signed-off-by: matttrach <matt.trachier@suse.com>
dereknola
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok, so the module keeps working when I run it from my workstation, but it fails in CI.
I noticed in the logs that the helm chart apply seems to be cut off at 18 minutes, so rather than trust the Helm provider to watch the progress I set the Helm provider not to wait for the chart to succeed before moving on. I then generated a resource that polls kubernetes watching for the pods to complete. I am hoping at the very least this will give us a better understanding of what is causing the CI to fail.