Adding Neuvector pipeline scripts for allinone regression tests #387
Conversation
| stage('Execution') { | ||
| withCredentials([string(credentialsId: 'NEUVECTOR_PASSWORD', variable: 'NEUVECTOR_PASSWORD')]) { | ||
| sh ''' | ||
| sshpass -p "$NEUVECTOR_PASSWORD" ssh [email protected] "/mnt/nfs/share/QA/automation/allinone_script.sh $NV_RELEASE_TAG $_DIR_ $JOB_NAME $BUILD_NUMBER" |
There was a problem hiding this comment.
I know these run behind the VPN but, I think it would be a good idea for best-practice to put these IPs in a jenkins secret instead
There was a problem hiding this comment.
is there a convention / reason these are just numbered names instead of something more descriptive we typically name based on what the test / job will be doing
There was a problem hiding this comment.
We have around 1000+ test cases that we execute on these so we split them across 7 servers to get the results in few hours. Hence we have the such naming convention i.e 1 to 7
| } | ||
| } |
There was a problem hiding this comment.
is there an indentation missing on these?
slickwarren
left a comment
slickwarren
left a comment
There was a problem hiding this comment.
lgtm. Do you already have a jenkins-job-builder PR too?
|
@slickwarren Yes I have the jenkins-job-builder ready for the jobs. I just want to make the SCM changes for these jobs in staging and verify it once before creating the pull request. |
|
@slickwarren Should I request with someone for merging this PR ?. |
|
@venkateshjayagopal you should be good to go, but if there's someone else on your team it would be nice to have them review it too for best practice. |
3 participants
Adding Neuvector pipeline scripts for allinone regression tests