Add Longhorn installation tests #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
commented
Nov 24, 2025
hamistao
force-pushed
the
longhorn_installation_tests
branch
from
c8c01b3 to
0cda9b4
Compare
hamistao
commented
Nov 26, 2025
Comment on lines
+116
to
+128
| // If Longhorn was installed by a previous test on this same session, uninstall it to install it again with custom configuration. | ||
| // If Longhorn was installed previously to this test run, leave it be and skip this test. This way we allow for running the | ||
| // next tests on top of a manually installed Longhorn and avoid accidentally uninstalling something important. | ||
| if chart.IsAlreadyInstalled { | ||
| if l.installedLonghorn { | ||
| l.T().Log("Uninstalling Longhorn that was intalled on the previous test.") | ||
| err = charts.UninstallLonghornChart(l.client, longhornNamespace, l.cluster.ID, l.payloadOpts.Host) | ||
| require.NoError(l.T(), err) | ||
| } else { | ||
| l.T().Skip("Skipping installation test because Longhorn is already installed") | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This decision was tricky and had some discussion surrounding it. From the outcome of the discussions I believe this is the way to go. This way we achieve
1- Running all tests at once with the suite;
2- Running some tests with a custom installation of longhorn;
3- Keep the cleanup logic neatly isolated;
Contributor
Author
There was a problem hiding this comment.
cc @rancher/qa-pit-crew
hamistao
commented
Nov 26, 2025
Comment on lines
+176
to
+181
| // Even though the Longhorn default for number of replicas is 2, Rancher enforces its own default of 3. | ||
| volumeName := nginxSpec.Template.Spec.Volumes[0].Name | ||
| checkReplicasCommand := []string{"kubectl", "-n", longhornNamespace, "get", "volumes.longhorn.io", volumeName, `-o=jsonpath="{.spec.numberOfReplicas}"`} | ||
| settingValue, err := kubectl.Command(l.client, nil, l.cluster.ID, checkReplicasCommand, "") | ||
| require.NoError(l.T(), err) | ||
| require.Equal(l.T(), "\"3\"\n", settingValue) |
Contributor
Author
There was a problem hiding this comment.
This behavior is very strange to me and I did not find anything explicitly stating that this is expected, but I assume it is the intended behavior and tested it as such. If you know of a better way to proceed here please let me know.
@rancher/qa-pit-crew
Signed-off-by: hamistao <[email protected]>
This is not required for the Longhorn tests. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
longhorn_installation_tests
branch
from
0cda9b4 to
264b9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first automated Longhorn interoperability tests, namely: