WIP: feat: move to fleet bundles for aws kubeadm #1248
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
kind/enhancement
salasberryfin
changed the title
salasberryfin
force-pushed
the
test-e2e-use-fleet-for-aws-ec2
branch
4 times, most recently
from
3fd02b6 to
844e997
Compare
mjura
reviewed
Apr 9, 2025
salasberryfin
force-pushed
the
test-e2e-use-fleet-for-aws-ec2
branch
6 times, most recently
from
34dfe99 to
3f87829
Compare
3 tasks
salasberryfin
force-pushed
the
test-e2e-use-fleet-for-aws-ec2
branch
2 times, most recently
from
c08089f to
e6486ca
Compare
mjura
reviewed
Apr 15, 2025
salasberryfin
force-pushed
the
test-e2e-use-fleet-for-aws-ec2
branch
5 times, most recently
from
dcf0609 to
c82a9c2
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
test-e2e-use-fleet-for-aws-ec2
branch
from
c82a9c2 to
aa71536
Compare
|
I'll split this PR to keep it more organized and simplify test validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Deprecate the use of
ClusterResourceSetfor installingcloud-controller-managerandebs-csi-driverwhen deploying AWS+Kubeadm clusters.Which issue(s) this PR fixes:
Fixes #1144
Fixes #1278
Fixes #1279
Special notes for your reviewer:
The existing Calico
HelmAppcould not be re-used because AWS requires a specific configuration (encapsulation, bgp, etc.), so a new file is added for AWS-only. As we use selectors on the class that was used to provision the cluster, this will only apply to the CAPA/CABPK scenario.AWS Cloud Controller Manager provides a Helm chart that does not support some of the parameters required to set a configuration equivalent to the one we use in the current CRS. For now we opted for creating a Fleet
Bundlethat manages the creation of the resources for AWS CCM. As a follow-up we should probably invest time on helping fixing the existing Helm chart upstream, see https://github.com/kubernetes/cloud-provider-aws/tree/master/charts/aws-cloud-controller-manager.Checklist: