fix: Use CAPIProvider's name to select resources #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
added
area/api
…t set Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
e2e_add_docker_spec_name
branch
from
4e7536e to
d9318c9
Compare
salasberryfin
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
CAPIProvider.spec.nameAPI is used inconsistently all over the place.In most scenarios it is defined, however there are cases (in tests and documentation), where it is not.
Turtles also does not seem to set the
CAPIProvider.spec.nameonce inferred from theCAPIProvider.metadata.name. It will just be empty.This PR is not a fix to the behavior, but just a workaround to be able to select provider's resources. A workaround will be needed in any case even after a fix to support migration from older Turtles versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: