Include ember-api-store addon in the code base #5184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this still needed? |
Member
Author
|
@mantis-toboggan-md not sure it is. This was to help us more easily migrate to newer versions of Ember - but I think we can only go as far as 3.28 - so don’t know if it I worth it. |
Member
Author
|
Won't fix ahead of removal of the legacy UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the code from https://github.com/rancher/ember-api-store and embeds it in the ui codebase.
ember-api-storeis currently published as an npm module which complicates Ember migration since we need to migrate both projects. By inlining the code, we only have to migrate the ui codebase.Note, there is a test directory, but as far as I can tell, this is all test framework and there are no tests, so this folder was removed.
I checked the dependencies and updated the
package.jsonfile to be consistent with the other addons. I added two dependencies to the top-level package file that look like they were needed (both cookie related).The lint rules for this project were different to the ones in the
uirepository, so fixed them automatically via eslint with the--fixoption.Tested manually by navigating around the UI, deploying a workload and scaling it up/down to check that the store operates as before.