Skip to content

Conversation

@frank-m
Copy link

@frank-m frank-m commented Dec 1, 2025

Problem

rancher-webhook does not support imagepullsecrets. When using private registries this can be very annoying as the main rancher chart does support them, but subsequent pulls will fail.

Solution

Added some yaml templating and tests to add imagepullsecrets. Also added default value.

CheckList

  • Test
  • Docs

@frank-m frank-m requested a review from a team as a code owner December 1, 2025 12:35
- Added ImagePullSecrets support to deployment.yaml
- Added unit tests for both the deployment.yaml
@tomleb
Copy link
Contributor

tomleb commented Dec 12, 2025

Hi @frank-m, first thanks for the contribution.

There's an on-going effort to add support for imagePullSecrets to a few other rancher components lead by another team so I believe we'll need this eventually, just not sure yet if as is fine or will need changes. Let me do some digging on that effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants