Validate PodDisruptionBudget and PriorityClass for fleetAgentDeploymentCustomization #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for both, PDB & PC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#52535 and rancher/rancher#52437
Problem
A new feature is being introduced to Rancher which allows users to define a Pod Disruption Budget and Priority Class on the v1.Cluster and v3.Cluster objects to better ensure HA of the fleet agent. In order to prevent use of the new fields added to the cluster objects when the feature is disabled, as well as to prevent incorrect configuration of the PC and PDB, additional validation needs to be added to the webhook.
#702 implemented the same checks for the cattle cluster agent.
Solution
Add additional logic to the validators for the v1.Cluster, v3.Cluster, and settings resources.
CheckList