feat: Add CI checks to ensure system-agent dependencies match#323
Open
HarrisonWAffel wants to merge 1 commit intorancher:mainfrom
Open
feat: Add CI checks to ensure system-agent dependencies match#323HarrisonWAffel wants to merge 1 commit intorancher:mainfrom
HarrisonWAffel wants to merge 1 commit intorancher:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the primary purpose of rancher-wins is to embed the system-agent, it's important that the dependencies defined for a given version of the system-agent are not overridden by the wins
go.modfile. This helps ensure that CVE's are resolved in the wins binary, and can potentially prevent unexpected behavior differences. However, this requirement / expectation is not well documented.This PR adds an explicit CI check to ensure that any overlapping dependencies between rancher-wins and the system-agent are set at the same version, or newer. This should help new contributors / first mates understand this expectation and identify when other dependencies need to be bumped in wins before a release.