bump k8s v1.36#665
Merged
Merged
Conversation
Abhishek-Valaboju
force-pushed
the
bump-k8v1.36
branch
6 times, most recently
from
f3a446d to
a4e31e7
Compare
Contributor
|
@mitulshah-suse -- any chance we can get this prioritized to help unblock other Rancher teams? |
|
@Jono-SUSE-Rancher we will get it in by Friday. |
Abhishek-Valaboju
force-pushed
the
bump-k8v1.36
branch
from
a4e31e7 to
dcc9e57
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates Wrangler’s Kubernetes dependencies to support Kubernetes v1.36 (client-go/api/apimachinery/etc.), along with the associated Go/tooling updates needed to compile and keep CI green.
Changes:
- Bump Kubernetes libraries from v0.35.0 to v0.36.0 and refresh related transitive dependencies (
go.mod/go.sum). - Update Go version targets (module
godirective and CI images/tooling) to Go 1.26. - Make small compatibility adjustments for updated dependencies (reflect kind checks,
io.ReadAll, updated client-go test stub interface).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/schemas/reflection.go | Adjust reflect kind checks for pointer handling. |
| pkg/relatedresource/changeset_test.go | Update test stub to satisfy updated client-go registration interface. |
| pkg/generic/fake/generate.go | Switch mock generation to go run go.uber.org/mock/mockgen. |
| pkg/crd/init.go | Adjust reflect kind checks for pointer handling. |
| pkg/controller-gen/main.go | Update deepcopy-gen invocation inputs for newer code-generator behavior. |
| pkg/controller-gen/args/groupversion.go | Adjust reflect kind check for pointer handling. |
| pkg/condition/condition.go | Adjust reflect kind checks for pointer handling. |
| pkg/apply/desiredset_compare.go | Replace deprecated ioutil.ReadAll with io.ReadAll. |
| go.mod | Bump Go version + k8s and related dependencies for v1.36 support. |
| go.sum | Dependency checksum updates consistent with module bumps. |
| .github/workflows/ci.yaml | Update CI to Go 1.26 and newer golangci-lint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crobby
approved these changes
May 7, 2026
joshmeranda
requested changes
May 7, 2026
ericpromislow
approved these changes
May 7, 2026
joshmeranda
approved these changes
May 7, 2026
brandond
approved these changes
May 7, 2026
aruiz14
suggested changes
May 8, 2026
aruiz14
approved these changes
May 8, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rancher/rancher#54303
add support for kubernetes v1.36