Skip to content

misc(summaryInformer): make ListWatcher context-aware #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aruiz14 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

misc(summaryInformer): make ListWatcher context-aware #668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6b853
misc(summaryInformer): make ListWatcher context-aware
aruiz14 May 8, 2026
6964945
fix: apply to all cases
aruiz14 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/summary/informer/informer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,17 @@ func NewFilteredSummaryInformerWithOptions(
tweakListOptions TweakListOptionsFunc,
) informers.GenericInformer {
lw := &cache.ListWatch{
ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
ListWithContextFunc: func(ctx context.Context, options metav1.ListOptions) (runtime.Object, error) {
if tweakListOptions != nil {
tweakListOptions(&options)
}
return client.ResourceWithOptions(gvr, opts).Namespace(namespace).List(context.TODO(), options)
return client.ResourceWithOptions(gvr, opts).Namespace(namespace).List(ctx, options)
},
WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
WatchFuncWithContext: func(ctx context.Context, options metav1.ListOptions) (watch.Interface, error) {
if tweakListOptions != nil {
tweakListOptions(&options)
}
return client.ResourceWithOptions(gvr, opts).Namespace(namespace).Watch(context.TODO(), options)
return client.ResourceWithOptions(gvr, opts).Namespace(namespace).Watch(ctx, options)
},
}
return &summaryInformer{
Expand All @@ -153,17 +153,17 @@ func NewFilteredSummaryInformerWithOptions(
// NewFilteredSummaryInformer constructs a new informer for a summary type.
func NewFilteredSummaryInformer(client client.Interface, gvr schema.GroupVersionResource, namespace string, resyncPeriod time.Duration, indexers cache.Indexers, tweakListOptions TweakListOptionsFunc) informers.GenericInformer {
lw := &cache.ListWatch{
ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
ListWithContextFunc: func(ctx context.Context, options metav1.ListOptions) (runtime.Object, error) {
if tweakListOptions != nil {
tweakListOptions(&options)
}
return client.Resource(gvr).Namespace(namespace).List(context.TODO(), options)
return client.Resource(gvr).Namespace(namespace).List(ctx, options)
},
WatchFunc: func(options metav1.ListOptions) (watch.Interface, error) {
WatchFuncWithContext: func(ctx context.Context, options metav1.ListOptions) (watch.Interface, error) {
if tweakListOptions != nil {
tweakListOptions(&options)
}
return client.Resource(gvr).Namespace(namespace).Watch(context.TODO(), options)
return client.Resource(gvr).Namespace(namespace).Watch(ctx, options)
},
}
return &summaryInformer{
Expand Down