Skip to content

Unify dialogs structure and behavior #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paleloser merged 2 commits into from
Jun 23, 2025
Merged

Unify dialogs structure and behavior #36

paleloser merged 2 commits into from
Jun 23, 2025

Conversation

@paleloser
Copy link
Collaborator

@paleloser paleloser commented May 30, 2025

Key changes of this refactor:

  • Modals have been moved to a comon components/Helm directory, since they are used in different pages.
  • Every dialog uses a common Modal object which ensures the same look&feel
  • States have been aligned to match the same names and values

@paleloser paleloser requested a review from a team as a code owner May 30, 2025 13:26
@paleloser paleloser merged commit b3d976b into main Jun 23, 2025
5 checks passed
@paleloser paleloser deleted the unify-modals branch June 23, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andresbono andresbono andresbono approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paleloser @andresbono