Added rancher-proxy package, proxy changes for custom clusters and rke2 packages#68
Open
MSpencer87 wants to merge 2 commits intorancherlabs:mainfrom
Open
Added rancher-proxy package, proxy changes for custom clusters and rke2 packages#68MSpencer87 wants to merge 2 commits intorancherlabs:mainfrom
MSpencer87 wants to merge 2 commits intorancherlabs:mainfrom
Conversation
caliskanugur
reviewed
Nov 1, 2024
Comment on lines
+5
to
+12
| registry_ip: | ||
| type: string | ||
| readOnly: true | ||
| description: "Public IP address of the proxy bastion node" | ||
| registry_private_ip: | ||
| type: string | ||
| readOnly: true | ||
| description: "Private IP address of the proxy bastion node" |
caliskanugur
reviewed
Nov 1, 2024
Comment on lines
+7
to
+11
| export HTTP_PROXY=http://${CORRAL_registry_private_ip}:3219 | ||
| export HTTPS_PROXY=http://${CORRAL_registry_private_ip}:3219 | ||
| export http_proxy=http://${CORRAL_registry_private_ip}:3219 | ||
| export https_proxy=http://${CORRAL_registry_private_ip}:3219 | ||
| export proxy_host=${CORRAL_registry_private_ip}:3219 |
Contributor
There was a problem hiding this comment.
We already implemented half of the registry -> bastion rename output. Would this work if we used bastion_private_ip instead of registry_private_ip?
markusewalker
approved these changes
Nov 13, 2024
Contributor
markusewalker
left a comment
markusewalker
left a comment
There was a problem hiding this comment.
LGTM, awaiting offline confirmation that this is good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.