Skip to content

Update pattern in fulfillSignatureRequest #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
najienka merged 1 commit into from
Oct 2, 2025
Merged

Update pattern in fulfillSignatureRequest #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/signature-requests/SignatureSender.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {AccessControlEnumerableUpgradeable} from
import {Initializable} from "@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol";
import {UUPSUpgradeable} from "@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol";
import {ContextUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol";
import {ReentrancyGuard} from "@openzeppelin/contracts/utils/ReentrancyGuard.sol";
import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol";

import {TypesLib} from "../libraries/TypesLib.sol";
Expand All @@ -29,8 +28,7 @@ contract SignatureSender is
Multicall,
Initializable,
UUPSUpgradeable,
AccessControlEnumerableUpgradeable,
ReentrancyGuard
AccessControlEnumerableUpgradeable
{
using BytesLib for bytes;
using EnumerableSet for EnumerableSet.UintSet;
Expand Down Expand Up @@ -155,7 +153,7 @@ contract SignatureSender is

/// @notice Fulfils a unique signature request.
/// @dev See {ISignatureSender-fulfillSignatureRequest}.
function fulfillSignatureRequest(uint256 requestID, bytes calldata signature) external nonReentrant {
function fulfillSignatureRequest(uint256 requestID, bytes calldata signature) external {
require(isInFlight(requestID), "No request with specified requestID");
TypesLib.SignatureRequest memory request = requests[requestID];

Expand Down