initrd-shell: fix await_condition command execution - #123
Open
jaybent wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #122 which identifies two related bugs in the initrd runtime shell path:
await_condition()flattens its command arguments into a scalar withlocal command="$*"and later executes$commandunquoted. This losesargvboundaries and makes the condition sensitive to word splitting and pathname expansion.await_secret_validated()passes[[ ! has_crypt_jobs ]]as if it were a command. That does not callhas_crypt_jobs; inside[[ ... ]],has_crypt_jobsis a non-empty string, so the expression is always false.The fix is to execute
"$@"directly inawait_condition()and introduce a smallhas_no_crypt_jobs()predicate for the negated condition.