Skip to content

FIX: botan_x509_cert_is_ca() should return "1" for true #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reneme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: botan_x509_cert_is_ca() should return "1" for true #5236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/ffi/ffi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,7 @@ int botan_x509_cert_view_public_key_bits(botan_x509_cert_t cert, botan_view_ctx
BOTAN_FFI_EXPORT(2, 0) int botan_x509_cert_get_public_key(botan_x509_cert_t cert, botan_pubkey_t* key);

/**
* Returns 0 iff the cert is a CA certificate
* Returns 1 iff the cert is a CA certificate
*/
BOTAN_FFI_EXPORT(3, 11) int botan_x509_cert_is_ca(botan_x509_cert_t cert);

Expand Down
2 changes: 1 addition & 1 deletion src/lib/ffi/ffi_cert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ int botan_x509_cert_load(botan_x509_cert_t* cert_obj, const uint8_t cert_bits[],

int botan_x509_cert_is_ca(botan_x509_cert_t cert) {
#if defined(BOTAN_HAS_X509_CERTIFICATES)
return BOTAN_FFI_VISIT(cert, [=](const auto& c) { return c.is_CA_cert() ? BOTAN_FFI_SUCCESS : 1; });
return BOTAN_FFI_VISIT(cert, [=](const auto& c) { return c.is_CA_cert() ? 1 : 0; });
#else
BOTAN_UNUSED(cert);
return BOTAN_FFI_ERROR_NOT_IMPLEMENTED;
Expand Down
4 changes: 2 additions & 2 deletions src/tests/test_ffi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,13 +806,13 @@ class FFI_Cert_Validation_Test final : public FFI_Test {
if(!TEST_FFI_INIT(botan_x509_cert_load_file, (&root, Test::data_file("x509/nist/root.crt").c_str()))) {
return;
}
TEST_FFI_RC(0, botan_x509_cert_is_ca, (root));
TEST_FFI_RC(1, botan_x509_cert_is_ca, (root));

botan_x509_cert_t end2;
botan_x509_cert_t sub2;
REQUIRE_FFI_OK(botan_x509_cert_load_file, (&end2, Test::data_file("x509/nist/test02/end.crt").c_str()));
REQUIRE_FFI_OK(botan_x509_cert_load_file, (&sub2, Test::data_file("x509/nist/test02/int.crt").c_str()));
TEST_FFI_RC(1, botan_x509_cert_is_ca, (end2));
TEST_FFI_RC(0, botan_x509_cert_is_ca, (end2));

size_t path_limit;
TEST_FFI_RC(BOTAN_FFI_ERROR_NO_VALUE, botan_x509_cert_get_path_length_constraint, (root, &path_limit));
Expand Down
Loading