Skip to content

Conversation

dyceron
Copy link
Contributor

@dyceron dyceron commented Jan 10, 2025

  • Cleans up some values/variables on various structs
  • Adds new classes and functions

TODO: Add support for adding new points to a polygon

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (b0de65a) to head (3c528a6).

Files with missing lines Patch % Lines
...ercury_engine_data_structures/formats/collision.py 92.42% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   77.62%   77.65%   +0.03%     
==========================================
  Files          79       79              
  Lines        4027     4082      +55     
==========================================
+ Hits         3126     3170      +44     
- Misses        901      912      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyceron dyceron marked this pull request as ready for review January 11, 2025 04:10
@dyceron dyceron requested a review from duncathan January 11, 2025 04:10
Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current approach stalled on the construct release, I think the only way to implement this without losing compile() support is to make a new class for BoundingBox2D which inherits from Construct and implements a _emitparse() and _emitbuild() function.

@dyceron
Copy link
Contributor Author

dyceron commented Feb 12, 2025

With the current approach stalled on the construct release, I think the only way to implement this without losing compile() support is to make a new class for BoundingBox2D which inherits from Construct and implements a _emitparse() and _emitbuild() function.

I'm not familiar with either of those, so I'll need guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants