-
Notifications
You must be signed in to change notification settings - Fork 10
Updates to collision.py
#264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 77.62% 77.65% +0.03%
==========================================
Files 79 79
Lines 4027 4082 +55
==========================================
+ Hits 3126 3170 +44
- Misses 901 912 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current approach stalled on the construct release, I think the only way to implement this without losing compile()
support is to make a new class for BoundingBox2D
which inherits from Construct
and implements a _emitparse()
and _emitbuild()
function.
I'm not familiar with either of those, so I'll need guidance. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
TODO: Add support for adding new points to a polygon